-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Reddit node to fetch user Saved posts #2575
Conversation
Hey @m4tt72, I have just been reviewing this one and the breaking change bugs me a bit but before I add it to the breaking changes list am I right in thinking you can only get the saved posts of the currently logged in user? |
Hello @Joffcom, Correct, this change will allow a logged in reddit user to fetch their saved posts. I use this to save my saved Reddit posts into a database. |
Perfect, we were just trying to think about how we can handle it without introducing a breaking where possible. We have a solution which I will push to this commit shortly 👍 |
Hey @m4tt72, It wouldn't let me push the changes to this PR, Not sure if that was because you used your master branch instead of making a new branch for the change but what I have done is made a new PR here: #3034 which contains the change you made tweaked a bit 👍🏻 What I will do is close this PR and if you have any questions you can pop them on here or on the new PR, Thanks for spending the time on this PR. |
Got released with |
This might contain breaking changes since the User resource on the Reddit node now requires credentials.
Also added a
.nvmrc
to make it easy for nvm users to switch node version